Skip to content

show percentage savings after showing optimal size change #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odeke-em opened this issue Nov 6, 2020 · 0 comments · Fixed by #26
Closed

show percentage savings after showing optimal size change #23

odeke-em opened this issue Nov 6, 2020 · 0 comments · Fixed by #26

Comments

@odeke-em
Copy link
Member

odeke-em commented Nov 6, 2020

Right now we just show numeric values in improvements, but it might be useful and create easier buy-in if we can show how much has been saved, especially after adding support for size classes as per #22 (comment) so

<LINENO_POS>: struct has size 112 (size class <CLASS_SIZE>), rearrange to
<REARRANGEMENT> for optimal size (<PERCENT_DECREASE>% savings)
cuonglm pushed a commit that referenced this issue Nov 6, 2020
@cuonglm
Show percentage savings in report
7ca9761 
Fixes #23
@cuonglm cuonglm mentioned this issue Nov 6, 2020
Merged
cuonglm pushed a commit that referenced this issue Nov 6, 2020
@cuonglm
Show percentage savings in report
ae8f83d 
Fixes #23
cuonglm pushed a commit that referenced this issue Nov 6, 2020
@cuonglm
Show percentage savings in report
4a91a9a 
Fixes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show percentage savings in report orijtech/structslop
1 participant
@odeke-em