Skip to content

Fix the tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dannystaple opened this issue Mar 3, 2021 · 4 comments
Closed

Fix the tests #8

dannystaple opened this issue Mar 3, 2021 · 4 comments
Labels
bug

Comments

@dannystaple
Copy link
Member

Find a way to unit test some parts of this - it may require mocking at the usb library level.
@dannystaple
Copy link
Member Author

See https://github.com/orionrobots/python_usb_robot_arm/blob/main/tests/test_usb_arm.py - seems I already did this 4 years ago.

@dannystaple
Copy link
Member Author

I should probably throw in some github workflows to run it.

@dannystaple dannystaple changed the title Add some tests Fix the tests Jan 25, 2025
@dannystaple
Copy link
Member Author

I had some, with workflows, and broke them by renaming the main branch. Trying to unbreak in PR #21

@dannystaple
Copy link
Member Author

The name is a bit off for the packaging.
usb_arm is a bit generic, as is usb_robot_arm - both are seen here.
Something more specific, involving owi edge maplin maybe...
owi_maplin_usb_arm? I'm not going to rename the repo (right now), but the package can be.

dannystaple added a commit that referenced this issue Jan 25, 2025
@dannystaple
Merge pull request #21 from orionrobots/enable-test-workflows
2b420af 
Fix the test workflows #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dannystaple