Skip to content

switch from /etc/fstab to root flags karg #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cgwalters opened this issue Dec 13, 2024 · 3 comments · Fixed by #864
Closed

switch from /etc/fstab to root flags karg #756

cgwalters opened this issue Dec 13, 2024 · 3 comments · Fixed by #864
Assignees
@achilleas-k
Labels
bug Something isn't working

Comments

@cgwalters
Copy link
Contributor

See bootc-dev/bootc#971
TL;DR let's stop writing /etc/fstab by default and switch to root=UUID= (and rootflags= where needed).
@cgwalters cgwalters mentioned this issue Dec 13, 2024
Open
@cgwalters
Copy link
Contributor Author

Related to this we had a report on internal chat that having a container that includes /etc/fstab user content gets replaced by that generated by bib. Looks to me like the stage makes no attempt at merging.

So if we stopped writing /etc/fstab we'd indirectly fix this bug.

@cgwalters cgwalters added the bug Something isn't working label Jan 20, 2025
@achilleas-k achilleas-k self-assigned this Feb 24, 2025
achilleas-k added a commit to achilleas-k/images that referenced this issue Feb 26, 2025
@achilleas-k
image: always use mount units for bootc disk images
ed9e42b 
See osbuild/bootc-image-builder#756
achilleas-k added a commit to achilleas-k/images that referenced this issue Feb 26, 2025
@achilleas-k
image: always use mount units for bootc disk images
011df51 
See osbuild/bootc-image-builder#756
achilleas-k added a commit to achilleas-k/images that referenced this issue Feb 27, 2025
@achilleas-k
image: always use mount units for bootc disk images
48874e2 
See osbuild/bootc-image-builder#756
@aussielunix aussielunix mentioned this issue Mar 2, 2025
Open
achilleas-k added a commit to achilleas-k/images that referenced this issue Mar 3, 2025
@achilleas-k
image: always use mount units for bootc disk images
5668616 
See osbuild/bootc-image-builder#756
achilleas-k added a commit to achilleas-k/images that referenced this issue Mar 4, 2025
@achilleas-k
image: always use mount units for bootc disk images
53b649c 
See osbuild/bootc-image-builder#756
achilleas-k added a commit to achilleas-k/images that referenced this issue Mar 4, 2025
@achilleas-k
image: always use mount units for bootc disk images
19a575c 
See osbuild/bootc-image-builder#756
achilleas-k added a commit to achilleas-k/images that referenced this issue Mar 4, 2025
@achilleas-k
image: always use mount units for bootc disk images
49f654e 
See osbuild/bootc-image-builder#756
achilleas-k added a commit to achilleas-k/images that referenced this issue Mar 4, 2025
@achilleas-k
image: always use mount units for bootc disk images
d5ac9d3 
See osbuild/bootc-image-builder#756
@cgwalters cgwalters mentioned this issue Mar 7, 2025
Closed
achilleas-k added a commit to achilleas-k/images that referenced this issue Mar 7, 2025
@achilleas-k
image: always use mount units for bootc disk images
df385eb 
See osbuild/bootc-image-builder#756
github-merge-queue bot pushed a commit to osbuild/images that referenced this issue Mar 10, 2025
@achilleas-k @supakeen
image: always use mount units for bootc disk images
43f1a32 
See osbuild/bootc-image-builder#756
achilleas-k added a commit to achilleas-k/bootc-image-builder that referenced this issue Mar 26, 2025
@achilleas-k
go.mod: update osbuild/images to v0.127.0
c1b5381 
A major part of this update is the ability to use mount units instead of
defining mountpoints in /etc/fstab.

For bootc disk images, this is always enabled [1] and requires no
further configuration.

Closes osbuild#756

[1] osbuild/images@43f1a32
@achilleas-k achilleas-k mentioned this issue Mar 26, 2025
Merged
achilleas-k added a commit to achilleas-k/bootc-image-builder that referenced this issue Mar 28, 2025
@achilleas-k
go.mod: update osbuild/images to v0.128.0
cdf3bf2 
A major part of this update is the ability to use mount units instead of
defining mountpoints in /etc/fstab.

For bootc disk images, this is always enabled [1] and requires no
further configuration.

Closes osbuild#756

[1] osbuild/images@43f1a32
achilleas-k added a commit to achilleas-k/bootc-image-builder that referenced this issue Mar 28, 2025
@achilleas-k
go.mod: update osbuild/images to v0.129.0
2aa4e63 
A major part of this update is the ability to use mount units instead of
defining mountpoints in /etc/fstab.

For bootc disk images, this is always enabled [1] and requires no
further configuration.

Closes osbuild#756

[1] osbuild/images@43f1a32
github-merge-queue bot pushed a commit that referenced this issue Apr 1, 2025
@achilleas-k @supakeen
go.mod: update osbuild/images to v0.129.0
8bd5b39 
A major part of this update is the ability to use mount units instead of
defining mountpoints in /etc/fstab.

For bootc disk images, this is always enabled [1] and requires no
further configuration.

Closes #756

[1] osbuild/images@43f1a32
tulilirockz pushed a commit to centos-workstation/bootc-image-builder that referenced this issue Apr 8, 2025
@achilleas-k @tulilirockz
go.mod: update osbuild/images to v0.129.0
d9fdc94 
A major part of this update is the ability to use mount units instead of
defining mountpoints in /etc/fstab.

For bootc disk images, this is always enabled [1] and requires no
further configuration.

Closes osbuild#756

[1] osbuild/images@43f1a32
@musjj
Copy link

musjj commented Apr 21, 2025

The issue is closed, but I'm still seeing this problem.

On the latest version of bootc-image-builder with quay.io/fedora/fedora-bootc:42 as the base image, /etc/fstab still gets overwritten. And the module referenced above still exists on main: https://github.com/osbuild/osbuild/blob/50a6f2733ef2c4d8081020c9d7794713a17d46dc/stages/org.osbuild.fstab.

Any pointers here?

@achilleas-k
Copy link
Member

On the latest version of bootc-image-builder

Which version are you using exactly and from where? Can you provide an image ID for the bootc-image-builder container so I can check?

And the module referenced above still exists on main: https://github.com/osbuild/osbuild/blob/50a6f2733ef2c4d8081020c9d7794713a17d46dc/stages/org.osbuild.fstab.

That module isn't going anywhere. osbuild will always support building images with /etc/fstab. It's not only used for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achilleas-k achilleas-k

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go.mod: update osbuild/images to v0.128.0 achilleas-k/bootc-image-builder
3 participants
@cgwalters @achilleas-k @musjj