Skip to content

Conversation

engstk
Copy link

@engstk engstk commented Oct 14, 2024

No description provided.

@osm0sis
Copy link
Owner

osm0sis commented Oct 14, 2024

Yep good idea if it's not actually needed for everyone.

I still think PATCH_VBMETA_PARTITION would be a more correct/descriptive name for the feature, however.

Also, since it's a new feature you don't need to have the backwards compat variable entry. 👍

@engstk
Copy link
Author

engstk commented Oct 14, 2024

I think terminology is correct, since is different from what magisk does and should avoid similar lingo.
It's a skip to the check httols does while processing vbmeta in order to write the block, but will make it more clear.
It also should be false by default, since it's an exception.

@osm0sis
Copy link
Owner

osm0sis commented Oct 14, 2024

Let's settle on NO_VBMETA_PARTITION_PATCH=1 and call it a day? 😛

Confirmed all working on your side with your use case, I presume.

@osm0sis osm0sis merged commit fdf4603 into osm0sis:master Oct 14, 2024
basamaryan added a commit to basamaryan/AnyKernel3 that referenced this pull request Oct 14, 2024
* origin/master:
  AK3: add option to skip vbmeta patching while avb is enabled (osm0sis#90)
  AK3: fix Magisk check with magiskboot 27007+
  tools: update magisk utils to v28.0(28000) beta
mrsrimar22 added a commit to mrsrimar22/AnyKernel3 that referenced this pull request Oct 15, 2024
* origin/master:
  AK3: add option to skip vbmeta patching while avb is enabled (osm0sis#90)
  AK3: fix Magisk check with magiskboot 27007+
  tools: update magisk utils to v28.0(28000) beta

Change-Id: 9a4b59b7bae0d2f47ef66c3e64498ded7f46c90b
Signed-off-by: mrsrimar22 <[email protected]>
mrsrimar22 added a commit to mrsrimar22/AnyKernel3 that referenced this pull request Oct 15, 2024
* origin/master:
  AK3: add option to skip vbmeta patching while avb is enabled (osm0sis#90)
  AK3: fix Magisk check with magiskboot 27007+
  tools: update magisk utils to v28.0(28000) beta

Change-Id: 9a4b59b7bae0d2f47ef66c3e64498ded7f46c90b
Signed-off-by: mrsrimar22 <[email protected]>
chickendrop89 pushed a commit to chickendrop89/AnyKernel3 that referenced this pull request Oct 16, 2024
hanifardhani added a commit to hanifardhani/AnyKernel3 that referenced this pull request Oct 20, 2024
* github.com:osm0sis/AnyKernel3:
  AK3: add option to skip vbmeta patching while avb is enabled (osm0sis#90)
  AK3: fix Magisk check with magiskboot 27007+
  tools: update magisk utils to v28.0(28000) beta

Change-Id: Ie9e4e900fec9591dad2c83b17ac6285f226d0eac
kutemeikito added a commit to kutemeikito/AnyKernel3 that referenced this pull request Oct 24, 2024
* 'master' of https://github.com/osm0sis/AnyKernel3:
  AK3: add option to skip vbmeta patching while avb is enabled (osm0sis#90)
  AK3: fix Magisk check with magiskboot 27007+

Signed-off-by: Edwiin Kusuma Jaya <[email protected]>
kutemeikito added a commit to kutemeikito/AnyKernel3 that referenced this pull request Oct 24, 2024
…ynamic

* 'master' of https://github.com/osm0sis/AnyKernel3:
  AK3: add option to skip vbmeta patching while avb is enabled (osm0sis#90)
  AK3: fix Magisk check with magiskboot 27007+

Signed-off-by: Edwiin Kusuma Jaya <[email protected]>
LeCmnGend pushed a commit to LeCmnGend/AnyKernel3 that referenced this pull request Oct 28, 2024
LeCmnGend pushed a commit to LeCmnGend/AnyKernel3 that referenced this pull request Oct 28, 2024
ArbitraryFox pushed a commit to ArbitraryFox/AnyKernel3 that referenced this pull request Nov 7, 2024
rezaadi0105 pushed a commit to rezaadi0105/AnyKernel3 that referenced this pull request Feb 9, 2025
Flopster101 added a commit to FlopKernel-Series/AnyKernel3-trinket that referenced this pull request Mar 14, 2025
* https://github.com/osm0sis/AnyKernel3: (84 commits)
  tools: update magisk utils to v28.1(28100) stable
  AK3: add option to skip vbmeta patching while avb is enabled (osm0sis#90)
  AK3: fix Magisk check with magiskboot 27007+
  tools: update magisk utils to v28.0(28000) beta
  README: updated variable names
  anykernel: update for renamed user set variables
  AK3: replace remaining variables
  AK3: replace $home with $AKHOME
  AK3: remove $bin/ for tools now on path
  Backend: move tools higher in the PATH
  tools: update magisk utils to v27.0(27000) beta
  tools: update magisk utils to v26.4(26400) stable
  README: update for default system_dlkm flashing
  AK3: add system_dlkm.img flashing to write_boot function
  tools: update magisk utils to 0352ea2c(26302) canary
  AK3: separate dump failure and split failure
  Backend: improve modules rw remount output
  AK3: only allow repack of hdr v4 ramdisks as lz4-l
  Backend: work around KernelSU not processing modules on initial install
  README: boot_signer is deprecated, not the avb directory
  ...
iambinaytiwari pushed a commit to iambinaytiwari/AnyKernel3 that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants