Pip: Add a few sanity checks when parsing license information #5319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far phony packages have only been filtered out from the dependency tree, but they should also be removed from the list of installed packages. Signed-off-by: Sebastian Schuberth <[email protected]>
There are projects which put the full license text instead of just the license name into a license field. Omit such texts from the list of declared licenses by only accepting licenses that do not contain a newline character. Signed-off-by: Sebastian Schuberth <[email protected]>
mnonnenmacher
requested changes
May 4, 2022
The field is specified to be a "short string" which is "a single line of text, not more than 200 characters" [1]. Respect that limit, which also filters out cases where people add full license texts to the field. [1] https://docs.python.org/3/distutils/setupscript.html#additional-meta-data Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
pip-filter-phony-packages-2
branch
from
c05cda8 to
f9ec7f1
Compare
Codecov Report
@@ Coverage Diff @@
## main #5319 +/- ##
============================================
- Coverage 72.37% 72.37% -0.01%
- Complexity 1964 1966 +2
============================================
Files 260 260
Lines 13899 13900 +1
Branches 1960 1961 +1
============================================
Hits 10060 10060
Misses 2801 2801
- Partials 1038 1039 +1
Continue to review full report at Codecov.
|
mnonnenmacher
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.