Skip to content

Fix global links in KB Web cloud #8072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DoStupidThingsFasterWithMoreEnergy
Copy link
Contributor

The purpose of these pull requests (Fix global links in KB ...) is to replace all links referenced in /links with their /links values.

Example: replace all https://www.ovh.com/auth/?action=gotomanager&from=https://www.ovh.co.uk/&ovhSubsidiary=GB links with /links/manager.

I've seen that a lot have been replaced by your work, but I've also found a lot, which is why I'm making pr by kb.

These are not a priority, however, I think they can help you make the documentation source more consistent and can prevent possible errors.

Sorry for closing my last pull requests, but I noticed a first error followed by a second one... so I fixed them and for me it's now OK.

FYI it is also possible to automate it using the methods I mentioned in the issue: #8038

Be free to change the titles or to ask me any question.

Thank you for your reviews.

@Y0Coss no need for the Fix label, maybe Minor Update and even then, I'll let you be the judge.

Verified

This commit was signed with the committer’s verified signature.
rwgk Ralf W. Grosse-Kunstleve
@@ -188,7 +188,7 @@ After 24 hours, if your `DKIM` box is red, please refer to the section [“Why d

#### Full DKIM configuration <a name="firststep"></a>

To configure DKIM, go to the website <https://ca.api.ovh.com/console/>, log in using the `Login`{.action} button in the top right-hand corner, and enter your OVHcloud credentials.
To configure DKIM, go to the website </links/console>, log in using the `Login`{.action} button in the top right-hand corner, and enter your OVHcloud credentials.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These <> links won't work with our /links pattern. I'll work on adapting these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was my second error so ... sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you can and prefer i can remake these without <> links

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be much appreciated!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I close the pr named Fix global and I redo them avoiding the <> links ? is that good for you ? does it at least help you ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can do this... just change my regex...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I close the pr named Fix global and I redo them avoiding the <> links ? is that good for you ? does it at least help you ?

I've already merged a few of them and currently checking the Hosted Private Cloud one. If you know you've got other <> links edited in some other pull requests, you can edit those PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close before rewrite without <> links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've closed them all because I'm an idiot working mainly by script, as you've gathered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well all ... no ... those that were open

@DoStupidThingsFasterWithMoreEnergy DoStupidThingsFasterWithMoreEnergy deleted the Fix-global-links-in-kb-Web-cloud branch June 25, 2025 20:31
@DoStupidThingsFasterWithMoreEnergy
Copy link
Contributor Author

@Y0Coss
sorry for the delay. Are you still interested in these fixes? and can I present you with a pre-commit project and another via github action via my fork in the next few days?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants