You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@airween I don't know why PR #320 add me.
However, IMO, the similar PR #275 should be little better than PR #320.
PR #320 just fix compile error, however, it doesn't check modsecurity feature like #275.
@airween I don't know why PR #320 add me. However, IMO, the similar PR #275 should be little better than PR #320. PR #320 just fix compile error, however, it doesn't check modsecurity feature like #275.
Sorry, that's my fault. I think I wanted to add you to #352 where I did the same as you in #275. In PR I mentioned your PR.
For the sake of clarity: I collect merged PR's through GH API, and it tells me only the author of the PR. Then I review them and when I remember that I used another PR then I add the original author too. But it seems like I remembered wrong - sorry again.
5 commit comments
liudongmiao commentedon May 22, 2025
@airween I don't know why PR #320 add me.
However, IMO, the similar PR #275 should be little better than PR #320.
PR #320 just fix compile error, however, it doesn't check modsecurity feature like #275.
airween commentedon May 22, 2025
Sorry, that's my fault. I think I wanted to add you to #352 where I did the same as you in #275. In PR I mentioned your PR.
Sorry again.
airween commentedon May 22, 2025
For the sake of clarity: I collect merged PR's through GH API, and it tells me only the author of the PR. Then I review them and when I remember that I used another PR then I add the original author too. But it seems like I remembered wrong - sorry again.
airween commentedon May 22, 2025
@liudongmiao fixed in CHANGES.
liudongmiao commentedon May 28, 2025
@airween Thanks.
I just don't want to be credited if I shouldn't.