Fix @rbl operator to correctly recognize known supported RBL providers #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhora
added
bug
|
Merged ;) thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @rbl operator was found to not be working for some known providers including HttpBL as the current URL (dnsbl.httpbl.org) was not matching to be able to set the HttpBlKey or set the additional furtheInfo() data.
The previous string comparison was replaced with string::find to match with URLs under "httpbl.org" (and other predefined providers) domain as opposed to replacing the provider URL with the one in the API.
Matching the implementation of @rbl for ModSecurity v2 which uses std:strstr to scan the *string for the predefined RBL providers: https://github.com/SpiderLabs/ModSecurity/blob/v2/master/apache2/re_operators.c#L3670