Skip to content

fix: @pmFromFile with multiple files issue #3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

airween
Copy link
Member

@airween airween commented Jun 19, 2025

what

This PR fixes the @pmFromFile operator's behavior in case of multiple files.

why

@pmFromFile documentation says the operator allows multiple files, not just one. But it seems like the current behavior does not follows it.

references

Closes #3403.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@airween airween requested review from theseion and fzipi June 19, 2025 20:10
Copy link
Contributor

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airween airween merged commit cf24aea into owasp-modsecurity:v3/master Jun 20, 2025
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModSecurity v3 doesn't supports using multiple files with @pmFromFile
3 participants