Skip to content

Conversation

jvillafanez
Copy link
Member

Known issue caused by this PR: only one password-protected link can be accessed at a time.

  1. Access to a shared folder that is password-protected. Enter the password and check you can open text files inside.
  2. In a different tab, access to a different shared folder that is password-protected. Enter the password and check you can open text files inside
  3. Authentication for the first shared folder (step 1) is lost:
    • Trying to open a text file causes an error
    • You'll need to reload the page and enter the password again. Note that this will cause the same problem in the second tab.

Side note: whether the link has been authenticated or not is stored by core. Right now, this information is stored just for one share. Fixing the issue explained above will require changes in core.

@jvillafanez jvillafanez self-assigned this Sep 10, 2025
@CLAassistant
Copy link

CLAassistant commented Sep 10, 2025

CLA assistant check
All committers have signed the CLA.

@jvillafanez jvillafanez changed the title fix: ensure password has been checked for password-protected shares fix: ensure password has been checked for password-protected shares and have permissions to read the file Sep 12, 2025
Copy link

@jvillafanez jvillafanez merged commit 8fad2b5 into master Sep 15, 2025
3 checks passed
@jvillafanez jvillafanez deleted the load_protected_text branch September 15, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants