Fix ItemButton padding for downstate #1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bemusementpark
force-pushed
the
ItemButton
branch
from
d71e0a9 to
54c0f8a
Compare
bemusementpark
force-pushed
the
ItemButton
branch
from
54c0f8a to
73b0088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Padding seems to be set in the wrong place, which cuts off the downstate to some arbitrary position that doesn't line up with anything. This PR reinstates previous behaviour where downstate would extend to edges, matching iOS' downstate dimensions.
Before
After
TextButtonuses some defaultcontentPaddingwith horizontal padding of12 dpwhich is a bit awkward, so this PR setscontentPadding = PaddingValues()effectively removing content padding so it can all be set explicitly.This PR utilises some square space around the icon with an additional xxsSpacing horizontal padding to keep space on each side of the icon equal, and slightly more indented than the divider, which seems to match iOS.