Skip to content

Conversation

SessionHero01
Copy link
Collaborator

@SessionHero01 SessionHero01 commented Sep 24, 2024

Safe guard a few places so exception cases be handled:

  1. When deleting the space after a mention, the span will occupy the trailing of the text, which will have a special case of end offset == string length. Addition to it is definitely not going to go well.
  2. When deleting the space after a mention, then start another mention, it will create a mention span overlap, which will also crash the app. The normalisation will also need to take this into consideration.

@ThomasSession ThomasSession merged commit 439ec90 into release/1.20.0 Sep 24, 2024
2 checks passed
@ThomasSession ThomasSession deleted the fix-mention-crash branch September 24, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants