Feature/strings nice to haves #1686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleaned up older references to align with newer look
Cleaning unused code
…from the db directly
Split the `BASE_DELETED_TYPE` into two types: BASE_DELETED_OUTGOING_TYPE and BASE_DELETED_INCOMING_TYPE so we can differentiate them visually.
Still need to finalise "note to self" and "legacy groups"
Moving away from promises
Hndling unsend request retrieval as per figma docs
Sharing admin logic
Also rethemed the send buttona dn home plus button to have better ax contrast by standardising the colour displayed on the accent color to be the same as the one on the sent messages
We removed the 'delete locally' dialog, instead we show the 'delete for everyone' with the second option disabled
Cleaned up invisible copy button on black bgs
…lly updated in the settings page. This can be simplified once we make SharedPreferences widely accessible as Flows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES-2780 - Worked on the "Nice to haves" from the String tests.
SES-2801 - Made sure the hiding of the recovery password was done in a reactive way. I left a note to simplify this once we make our SharedPrefs accessible as Flows.