Fix/message deletion issues #1696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as only the labels change
Message view hides reactions completely if the message is marked as deleted All messages can now show the 'Delete' long press option Community messages should be removed completely not marked as deleted
This reverts commit 711e31a.
AL-Session
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
LGTM.
As this PR removes the screen security setting is it worth opening a JIRA ticket on what the issue is and why we removed it, then point the ticket at this PR and close it? Otherwise we have no easy way to find when/why we removed the functionality as it's not tied to any ticket, it just 'happened'.
Thanks. The ticket is the first one linked in the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES-2810 - Removed the unecessary screenshot toggle
SES-2813 - Made the disappearing control message only clickable in the right circumstances
SES-2815 - Proper icon and styling for 'marked as deleted' messages
SES-2816 - Proper deletion modal for community messages
SES-2817 - Adding ability for non admins in communities to delete messages
SES-2819 - Do not show reactions to messages that were 'marked as deleted'
Simplified the deletion dialogs and also made sure that 'deleted for everyone' messages in communitites left nothing behind instead of leaving a 'marked as deleted' message.