Fix/message deletion issues #1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as only the labels change
Message view hides reactions completely if the message is marked as deleted All messages can now show the 'Delete' long press option Community messages should be removed completely not marked as deleted
This reverts commit 711e31a.
…ithout using 'marked as deleted' messages
…tead refresh the sarch on resume
AL-Session
approved these changes
Oct 21, 2024
| } | ||
| } | ||
|
|
||
| public @Nullable MessageRecord getNonDeletedMessageForTimestamp(long timestamp) { |
There was a problem hiding this comment.
Isn't a non-deleted message just a message? Perhaps getMessageForTimestamp?
Ah, we now have messages with a 'deleted' type in the database.... that's a kinda odd way to go about things, but another way you could think of it is that the message is kinda in the "Recycle Bin" / "Trash" whatever you want to call it, so could potentially be recovered if required (but we never do and just clean that stuff out).
So okay, I guess...
There was a problem hiding this comment.
Yeah a message can be completely gone or marked as deleted. It still exists in the db and shows up as a special case message with the bin icon and a label like 'This message was deleted for everyone'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES-2817 - Making sure the deletion is available in the app bar menu in all cases as the deletion logic is now handled in the VM
SES-2811 - Making sure we do not attempt to send messages marked as deleted
SES-2818 - Updating the logic obtaining the 'lastMessage' of a thread, taking into account whether they were marked as deleted or not
SES-2464 - Changed the logic when finishing a conversation activity from a deleted thread. It now calls finish again but the home screen will refresh the search on resume if the search is visible