Add special-case handling for measurement token handoff #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbott
reviewed
Jul 15, 2025
| // reboot loop. The memory address and token values are hard-coded based on | ||
| // the `measurement-token` crate in Hubris. | ||
| if hubris.manifest.features.iter().any(|s| s == "measurement-handoff") { | ||
| core.reset_and_halt(std::time::Duration::from_millis(25))?; |
There was a problem hiding this comment.
Do we want to make this time a constant in measurement-token too?
There was a problem hiding this comment.
I don't think so – it's a Humility-specific delay, so it doesn't need to be coordinated between repositories.
mkeeter
force-pushed
the
mkeeter/measurement-token-handoff
branch
3 times, most recently
from
f867a1c to
654d4f3
Compare
mkeeter
force-pushed
the
mkeeter/measurement-token-handoff
branch
2 times, most recently
from
615337d to
8fe8b1c
Compare
labbott
approved these changes
Jul 28, 2025
mkeeter
force-pushed
the
mkeeter/measurement-token-handoff
branch
from
0539fb9 to
c418035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(opening this as a draft while we wait for oxidecomputer/lpc55_support#94)
Without this change, the SP's "multiple seconds of resets" in oxidecomputer/hubris#2138 cause Humility to time out. We could increase Humility's timeout, but having an explicit
SKIPtoken seems like a cleaner solution; with the SWD dongle attached, the SP is definitely not getting measured!