Fix typo in server metric CLI argument #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
force-pushed
the
fix-server-cli-typo
branch
2 times, most recently
from
6aef331 to
d4ebeb7
Compare
|
I goofed in #724 by renaming the server CLI flag from |
hawkw
approved these changes
Jul 26, 2024
A previous commit changed the name of the metric registration CLI command, but did not also change the name of flag in the SMF manifest or method script. This fixes the original introduced typo, keeping the SMF parts unchanged.
bnaecker
force-pushed
the
fix-server-cli-typo
branch
from
d4ebeb7 to
5ff4a8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit changed the name of the metric registration CLI command, but did not also change the name of flag in the SMF manifest or method script. This fixes the original introduced typo, keeping the SMF parts unchanged.