Add withConjureErrorParameterFormat option to WithClientOptions
#3192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
bjlaub
reviewed
Aug 15, 2025
client-config/src/main/java/com/palantir/conjure/java/clients/ConjureClients.java
Outdated
Show resolved
Hide resolved
mpritham
changed the title
withConjureErrorParameterSerializationFormat option to WithClientOptionswithConjureErrorParameterFormat option to WithClientOptions
✅ Successfully generated changelog entry!What happened?Your changelog entries have been stored in the database as part of our migration to ChangelogV3. Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. |
mpritham
commented
Aug 18, 2025
|
|
||
| dependencies { | ||
| api 'com.palantir.conjure.java.api:service-config' | ||
| api 'com.palantir.conjure.java.api:errors' |
There was a problem hiding this comment.
This is needed because ConjureErrorParameterFormat is defined in com.palantir.conjure.java.api:errors
aldexis
reviewed
Aug 20, 2025
.palantir/revapi.yml
Outdated
Comment on lines
88
to
91
| - code: "java.method.removed" | ||
| old: "method T com.palantir.conjure.java.clients.ConjureClients.WithClientOptions<T>::withConjureErrorParameterSerializationFormat(com.palantir.conjure.java.api.errors.ConjureErrorParameterFormat)" | ||
| justification: "Adding method to allow clients to request error parameter serialization\ | ||
| \ format" |
There was a problem hiding this comment.
Which part was weird? If it was because the break was on an RC release, that has been fixed.
There was a problem hiding this comment.
I think I might have meant that it was saying a method was removed
mpritham
force-pushed
the
pm/proto-header
branch
from
e3f7b7b to
836ccde
Compare
aldexis
approved these changes
Sep 22, 2025
|
Released 8.25.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
I'd like to enable clients to set the desired error parameter format. We currently don't have a method on Dialogue's
ReloadingFactoryto do so.After this PR
==COMMIT_MSG==
Add
withConjureErrorParameterFormatoption toWithClientOptions==COMMIT_MSG==
Possible downsides?