Skip to content

Extend FilterInputStream and use the stream directly #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.spark.shuffle.api;

import java.io.FilterInputStream;
import org.apache.spark.storage.BlockId;

import java.io.InputStream;
Expand All @@ -26,20 +27,15 @@
* An object defining the shuffle block and length metadata associated with the block.
* @since 3.0.0
*/
public class ShuffleBlockInputStream {
public class ShuffleBlockInputStream extends FilterInputStream {
private final BlockId blockId;
private final InputStream inputStream;

public ShuffleBlockInputStream(BlockId blockId, InputStream inputStream) {
super(inputStream);
this.blockId = blockId;
this.inputStream = inputStream;
}

public BlockId getBlockId() {
return this.blockId;
}

public InputStream getInputStream() {
return this.inputStream;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ private[spark] class BlockStoreShuffleReader[K, C](
}
}.asJava).iterator()

val retryingWrappedStreams = streamsIterator.asScala.map { shuffleBlock =>
val rawReaderStream = shuffleBlock.getInputStream
val retryingWrappedStreams = streamsIterator.asScala.map { rawReaderStream =>
if (shuffleExecutorComponents.shouldWrapPartitionReaderStream()) {
if (compressShuffle) {
compressionCodec.compressedInputStream(
Expand Down
2 changes: 1 addition & 1 deletion project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
addSbtPlugin("com.typesafe.sbt" % "sbt-git" % "0.8.5")
addSbtPlugin("com.typesafe.sbt" % "sbt-git" % "1.0.0")

addSbtPlugin("com.etsy" % "sbt-checkstyle-plugin" % "3.1.1")

Expand Down