Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 109 additions & 0 deletions src/Drupal10/Rector/Deprecation/RenameClassRector.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
<?php

declare(strict_types=1);

namespace DrupalRector\Drupal10\Rector\Deprecation;

use DrupalRector\Contract\VersionedConfigurationInterface;
use DrupalRector\Drupal10\Rector\ValueObject\RenameClassRectorConfiguration;
use DrupalRector\Rector\AbstractDrupalCoreRector;
use DrupalRector\Rector\ValueObject\DrupalIntroducedVersionConfiguration;
use PhpParser\Node;
use PhpParser\Node\FunctionLike;
use PhpParser\Node\Name\FullyQualified;
use PhpParser\Node\Stmt\ClassLike;
use PhpParser\Node\Stmt\Expression;
use PhpParser\Node\Stmt\If_;
use PhpParser\Node\Stmt\Property;
use Rector\Configuration\RenamedClassesDataCollector;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Renaming\NodeManipulator\ClassRenamer;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

class RenameClassRector extends AbstractDrupalCoreRector
{
/**
* @var array|DrupalIntroducedVersionConfiguration[]
*/
protected array $configuration;

/**
* @readonly
*
* @var RenamedClassesDataCollector
*/
private $renamedClassesDataCollector;
/**
* @readonly
*
* @var ClassRenamer
*/
private $classRenamer;

public function __construct(RenamedClassesDataCollector $renamedClassesDataCollector, ClassRenamer $classRenamer)
{
$this->renamedClassesDataCollector = $renamedClassesDataCollector;
$this->classRenamer = $classRenamer;
}

/**
* {@inheritdoc}
*/
public function getNodeTypes(): array
{
return [FullyQualified::class, Property::class, FunctionLike::class, Expression::class, ClassLike::class, If_::class];
}

public function configure(array $configuration): void
{
foreach ($configuration as $value) {
if (!($value instanceof RenameClassRectorConfiguration)) {
throw new \InvalidArgumentException(sprintf('Each configuration item must be an instance of "%s"', RenameClassRectorConfiguration::class));
}
}

parent::configure($configuration);
}

public function refactorWithConfiguration(Node $node, VersionedConfigurationInterface $configuration)
{
$oldToNewClasses = $this->renamedClassesDataCollector->getOldToNewClasses();
if ($oldToNewClasses !== []) {
/** @var \PHPStan\Analyser\Scope $scope */
$scope = $node->getAttribute(AttributeKey::SCOPE);
$return = $this->classRenamer->renameNode($node, $oldToNewClasses, $scope);
if (!is_null($return)) {
$scope->getFile();

return $return;
}
}

return null;
}

/**
* {@inheritdoc}
*/
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Fixes deprecated watchdog_exception(\'update\', $exception) calls', [
new ConfiguredCodeSample(
<<<'CODE_BEFORE'
watchdog_exception('update', $exception);
CODE_BEFORE
,
<<<'CODE_AFTER'
use \Drupal\Core\Utility\Error;
$logger = \Drupal::logger('update');
Error::logException($logger, $exception);
CODE_AFTER
,
[
new DrupalIntroducedVersionConfiguration('10.1.0'),
]
),
]);
}
}
38 changes: 38 additions & 0 deletions src/Drupal10/Rector/ValueObject/RenameClassRectorConfiguration.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
<?php

declare(strict_types=1);

namespace DrupalRector\Drupal10\Rector\ValueObject;

use DrupalRector\Contract\VersionedConfigurationInterface;

class RenameClassRectorConfiguration implements VersionedConfigurationInterface
{
private string $introducedVersion;

private string $oldClass;

private string $newClass;

public function __construct(string $introducedVersion, string $oldClass, string $newClass)
{
$this->introducedVersion = $introducedVersion;
$this->oldClass = $oldClass;
$this->newClass = $newClass;
}

public function getIntroducedVersion(): string
{
return $this->introducedVersion;
}

public function getOldClass(): string
{
return $this->oldClass;
}

public function getNewClass(): string
{
return $this->newClass;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?php

declare(strict_types=1);

namespace DrupalRector\Tests\Drupal10\Rector\Deprecation\WatchdogExceptionRector;

use Iterator;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;

class RenameClassRectorTest extends AbstractRectorTestCase
{
/**
* @covers ::refactor
*
* @dataProvider provideData
*/
public function test(string $filePath): void
{
$this->doTestFile($filePath);
}

/**
* @return Iterator<<string>>
*/
public static function provideData(): \Iterator
{
return self::yieldFilesFromDirectory(__DIR__.'/fixture');
}

public function provideConfigFilePath(): string
{
// must be implemented
return __DIR__.'/config/configured_rule.php';
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?php

declare(strict_types=1);

use DrupalRector\Drupal10\Rector\ValueObject\RenameClassRectorConfiguration;
use DrupalRector\Tests\Rector\Deprecation\DeprecationBase;
use Rector\Config\RectorConfig;

return static function (RectorConfig $rectorConfig): void {
DeprecationBase::addClass(DrupalRector\Drupal10\Rector\Deprecation\RenameClassRector::class, $rectorConfig, false, [
new RenameClassRectorConfiguration('10.1.0', 'Drupal\\Tests\\field\\Traits\\EntityReferenceTestTrait', 'Drupal\\Tests\\field\\Traits\\EntityReferenceFieldCreationTrait'),
new RenameClassRectorConfiguration('10.1.0', 'Drupal\\OldClass', 'Drupal\\NewClass'),
]);
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?php

use Drupal\Tests\field\Traits\EntityReferenceTestTrait;

class EntityReferenceItemTest extends FieldKernelTestBase {

use EntityReferenceTestTrait;

}

?>
-----
<?php

use Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait;
use Drupal\Tests\field\Traits\EntityReferenceTestTrait;

class EntityReferenceItemTest extends FieldKernelTestBase {

use EntityReferenceFieldCreationTrait;

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<?php

use Drupal\Tests\field\Traits\EntityReferenceTestTrait;

class EntityReferenceItemTest extends FieldKernelTestBase {

protected \Drupal\OldClass $class;

}

?>
-----
<?php

use Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait;
use Drupal\Tests\field\Traits\EntityReferenceTestTrait;

class EntityReferenceItemTest extends FieldKernelTestBase {

protected \Drupal\NewClass $class;

}
Loading