Update Deny list to include to missing hooks and remove preprocess #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'update_last_removed', | ||
| ]; | ||
| if (in_array($hook, $procOnly) || str_starts_with($hook, 'preprocess') || str_starts_with($hook, 'process')) { | ||
| if (in_array($hook, $procOnly)) { |
There was a problem hiding this comment.
|| preg_match('/^(post_update_|update_\d+$)/', $hook) is missing in line 258. see checkForProceduralOnlyHooks in https://git.drupalcode.org/project/drupal/-/blob/11.2.x/core/lib/Drupal/Core/Hook/HookCollectorPass.php?ref_type=heads#L585
There was a problem hiding this comment.
It is not missing, this script does not run on .install or post_update files so those hooks will not be affected.
There was a problem hiding this comment.
These hooks aren't always in .install or post_update files.
There was a problem hiding this comment.
Can you share an example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two procedural only hooks we missed.
Also preprocess is now supported for 11.2.
To Test
Needs manual testing.
Drupal.org issue
https://www.drupal.org/project/drupal/issues/3524872