-
Notifications
You must be signed in to change notification settings - Fork 1
Refactored serial_api implementation. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored serial_api implementation. #3
Conversation
Not using Nordic SDK driver now, since it prevented interrupts from being handled properly.
Forgot to clean up after refactoring. Hence the second commit. |
+--------+----------------+-----------+---------+------------------+--------------------+---------------+-------+ It require a little bit more work I think, the tests MBED_37 and MBED_38 fail now. |
…c' and before TX_COMPLETE callback, corrected pins configuration routines.
…pan-/mbed into refactored_serial_api # Conflicts: # hal/targets/hal/TARGET_NORDIC/TARGET_NRF5/sdk/drivers_nrf/uart/nrf_drv_uart.c
Fixed.
|
The code looks OK. |
Looks very good, could you also launch mbed cli tests ? |
Results for 52:
|
mbed-cli tests
|
|
For IAR it's not that great.
|
|
|
It looks like there is an issue with the implementation of the standard library in IAR. |
|
removed static-declarations from header
Add <stdint.h> include to header
* Adding Cortex-A support for gnuarmeclipse * Preventing '-mthumb' from being added to Cortex-A builds. Previously, both '-mthumb' and '-marm' were being supplied to the compiler (in that order). Because '-marm' came last, the compiler respected this option. This change makes it so '-mthumb' is added for all 'Cortex-M' targets only. * Renaming to capital .S for Eclipse compatibility
* Review fixes. Changed apn, username and password to be dynamically allocated.
Change driver initialization behavior:
Signed-off-by: PARKJIHOON <[email protected]>
[IOTCELL-284] Removing NULL checks from Callbacks
Signed-off-by: PARKJIHOON <[email protected]>
Tested all the functionality. Seems to be working fine.
When using this implementation, the MBED_A9 test (serial echo at 115200) is passing for armcc as well.