-
-
Notifications
You must be signed in to change notification settings - Fork 143
Fix comment commands to source branches #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/pandas_nightly |
Well, I tried it above, and it skipped the job |
/pandas_nightly |
Can you retry? It was working fine when I ran it (maybe check for extra spaces) |
/pandas_nightly |
shows it is skipped: https://github.com/pandas-dev/pandas-stubs/actions/runs/13400980753 |
Okay will need to dig deeper on this one this is quite weird because I can trigger it and you can't |
even on your last trigger, it skipped it: https://github.com/pandas-dev/pandas-stubs/actions/runs/13401031918 |
/pandas_nightly |
/mypy_nightly |
/pandas_nightly |
@Dr-Irv I retried triggering the process a couple of times and haven't seen the issues we had earlier where the action would just not run at all. Please let me know if you are good with the changes. |
/pandas_nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @loicdiridollou
I tried it and it seemed to work |
So I think if I as a maintainer try it, it doesn't work, but it worked for you because you have access to your repo. See https://github.com/pandas-dev/pandas-stubs/actions/runs/13635376466 |
Fix comment commands to source branches to run nightly tests in correct repo
assert_type()
to assert the type of any return value