Skip to content

Fix comment commands to source branches #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

loicdiridollou
Copy link
Member

@loicdiridollou loicdiridollou commented Feb 18, 2025

Fix comment commands to source branches to run nightly tests in correct repo

@loicdiridollou loicdiridollou changed the title Fix comment commands to source branches to run nightly tests in corre… Fix comment commands to source branches Feb 18, 2025
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Feb 18, 2025

/pandas_nightly

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Feb 18, 2025

Well, I tried it above, and it skipped the job

@loicdiridollou
Copy link
Member Author

/pandas_nightly

@loicdiridollou
Copy link
Member Author

Can you retry? It was working fine when I ran it (maybe check for extra spaces)
Also those changes will only take effect once on main since it is not an action related to the PR itself (different classification at the header of the workflow file)

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Feb 18, 2025

/pandas_nightly

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Feb 18, 2025

Can you retry? It was working fine when I ran it (maybe check for extra spaces) Also those changes will only take effect once on main since it is not an action related to the PR itself (different classification at the header of the workflow file)

shows it is skipped: https://github.com/pandas-dev/pandas-stubs/actions/runs/13400980753

@loicdiridollou
Copy link
Member Author

Okay will need to dig deeper on this one this is quite weird because I can trigger it and you can't

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Feb 18, 2025

even on your last trigger, it skipped it: https://github.com/pandas-dev/pandas-stubs/actions/runs/13401031918

@loicdiridollou
Copy link
Member Author

/pandas_nightly

@loicdiridollou
Copy link
Member Author

/mypy_nightly

@loicdiridollou
Copy link
Member Author

/pandas_nightly

@loicdiridollou
Copy link
Member Author

@Dr-Irv I retried triggering the process a couple of times and haven't seen the issues we had earlier where the action would just not run at all. Please let me know if you are good with the changes.
Thanks

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Mar 3, 2025

/pandas_nightly

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit 71eaa0d into pandas-dev:main Mar 3, 2025
12 checks passed
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Mar 3, 2025

I tried it and it seemed to work

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Mar 3, 2025

So I think if I as a maintainer try it, it doesn't work, but it worked for you because you have access to your repo. See https://github.com/pandas-dev/pandas-stubs/actions/runs/13635376466

@loicdiridollou loicdiridollou deleted the gh1124_fix_comment_cmds branch March 9, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the comment command for nightly on a PR
2 participants