Type NAType
#1348
Merged
Type NAType
#1348
+423
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Aug 26, 2025
MarcoGorelli
commented
Aug 26, 2025
MarcoGorelli
commented
Aug 26, 2025
|
@MarcoGorelli pine me when I should review |
|
sure @Dr-Irv , happy for you to take a look, thanks! |
Dr-Irv
requested changes
Aug 26, 2025
…ndex` as they return `NotImplemented`
MarcoGorelli
commented
Sep 5, 2025
tests/test_natype.py
Outdated
| # ), | ||
| # tuple, | ||
| # ) | ||
| check(assert_type(na.__divmod__(1), tuple[NAType, NAType]), tuple) |
There was a problem hiding this comment.
i couldn't understand why, but this one fails if I write divmod(na, 1) instead, with
/home/marcogorelli/pandas-stubs-dev/tests/test_natype.py:105:23 - error: No overloads for "divmod" match the provided arguments (reportCallIssue)
/home/marcogorelli/pandas-stubs-dev/tests/test_natype.py:105:23 - error: "assert_type" mismatch: expected "tuple[NAType, NAType]" but received "Unknown" (reportAssertTypeFailure)
/home/marcogorelli/pandas-stubs-dev/tests/test_natype.py:105:34 - error: Argument of type "Literal[1]" cannot be assigned to parameter "y" of type "SupportsRDivMod[_T_contra@divmod, _T_co@divmod]" in function "divmod"
"Literal[1]" is incompatible with protocol "SupportsRDivMod[NAType, _T_co@divmod]"
"__rdivmod__" is an incompatible type
Type "(value: int, /) -> tuple[int, int]" is not assignable to type "(other: _T_contra@SupportsRDivMod, /) -> _T_co@SupportsRDivMod"
Parameter 1: type "_T_contra@SupportsRDivMod" is incompatible with type "int"
"NAType" is not assignable to "int" (reportArgumentType)There was a problem hiding this comment.
New pyright bug. microsoft/pyright#10899
Let's wait to get that resolved.
There was a problem hiding this comment.
thanks for reporting to them
looks like they haven't responded - reckon it's ok to revisit this detail later and move forwards with the rest for now? there's the issue open in their repo to track it
There was a problem hiding this comment.
Can you add a comment referring to the pyright issue?
Probably best to keep the test as divmod(na, 1) and put in a #pyright :ignore there
Dr-Irv
requested changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has uncovered a couple of bugs:
so some tests have their assertions ignored for now, but i've linked to them in those places