Skip to content

821 series diff timestamp2 #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 26, 2024
Merged

Conversation

mutricyl
Copy link
Contributor

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to merge with main so that the tests will run. Some small things I picked up.

@mutricyl mutricyl requested a review from Dr-Irv April 22, 2024 08:40
@mutricyl mutricyl requested a review from Dr-Irv April 25, 2024 20:53
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Apr 26, 2024

@mutricyl I'm fine with all of your changes, but the CI is failing on MacOS. It has something to do with tables.

Can you try updating pyproject.toml to refer to tables version 3.9.2 to see if that will fix the problem?

@mutricyl
Copy link
Contributor Author

tables 3.9.2 does not solve the issue apparently

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Apr 26, 2024

tables 3.9.2 does not solve the issue apparently

Ugh. We'll have to triage that against previous PR's that were working fine.

@twoertwein any ideas here? MacOS CI is failing because it can't build tables. I'm guessing this might be an architecture problem. Maybe we should lock MacOS to x86?

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Apr 26, 2024

tables 3.9.2 does not solve the issue apparently

Ugh. We'll have to triage that against previous PR's that were working fine.

@twoertwein any ideas here? MacOS CI is failing because it can't build tables. I'm guessing this might be an architecture problem. Maybe we should lock MacOS to x86?

I fixed the issue - changed macos-latest to macos-13 and it worked.

@mutricyl can you merge with the latest main and push ?

@mutricyl
Copy link
Contributor Author

@Dr-Irv , I'am done

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mutricyl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Series[Timestamp].diff() should return Series[Timedelta]
2 participants