-
-
Notifications
You must be signed in to change notification settings - Fork 143
821 series diff timestamp2 #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to merge with main
so that the tests will run. Some small things I picked up.
@mutricyl I'm fine with all of your changes, but the CI is failing on MacOS. It has something to do with tables. Can you try updating |
tables 3.9.2 does not solve the issue apparently |
Ugh. We'll have to triage that against previous PR's that were working fine. @twoertwein any ideas here? MacOS CI is failing because it can't build |
I fixed the issue - changed @mutricyl can you merge with the latest |
@Dr-Irv , I'am done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mutricyl
Closes
Series[Timestamp].diff()
should returnSeries[Timedelta]
#821Tests added: Please use
assert_type()
to assert the type of any return valuecheck function updated for series.diff particular usage
it looks like only first
assert_never
is actually checked so I created several test functions