Validate all values for csv.QUOTE

[refack]

4 and 5 added in 3.12 (python/cpython/67230)
ref: https://docs.python.org/3/library/csv.html#csv.QUOTE_NOTNULL
ref: https://github.com/python/cpython/blob/a8bc03696c7c2c03e1d580633151ec7b850366f3/Modules/_csv.c#L88-L106

• Tests added: Please use assert_type() to assert the type of any return value

[refack]

I didn't consider the fact that this will fail in python < 3.12 since the functionality is just not there...
I can put this test under a version check condition, but then should there be and if in the stub as well, one branch allowing literals up to 3 and the other up to 5?

[Dr-Irv]

Can you change this to use the references to csv.MINIMAL, csv.QUOTE_ALL, etc., You can do tests on the python version in a stub, e.g.,

if sys.version_info >= (3, 12):
    CSVQuoting: TypeAlias = Literal[csv.MINIMAL, #rest of values ]
else:
   CSVQuoting: TypeAlias = Literal[csv.MINIMAL, #rest of values]

[refack]

Literal[csv.MINIMAL] fails static analysis since csv.MINIMAL is not a python language literal (in hindsight it's obviously a language module member), but rather a runtime int using the constant naming convention

AFAICT the best we can do is document the values at runtime...

[Dr-Irv]

Oh, so maybe we should use Union[csv.MINIMAL, csv.QUOTE, # rest of values] instead.

[refack]

Sorry I'm both dyslexic and ESL 🤣

[refack]

Can we depend on typeshed? They have a stub for the compiled _csv code
https://github.com/python/typeshed/pull/12332/files#diff-c58bcb0a60afcd3168bd383c480870da81f23b9cec15e0890cf77d2306323240
(Even they recently moved from Literal to Final)

Never mind, the type checkers still don't want to infer the Type at static time, and the only importable Type is just _QuotingType: TypeAlias = int
https://github.com/python/typeshed/blob/e8e9291c76f50c3bcde79e7bb61060f5c24c054e/stdlib/_csv.pyi#L17-L19

[Dr-Irv]

Never mind, the type checkers still don't want to infer the Type at static time, and the only importable Type is just _QuotingType: TypeAlias = int
https://github.com/python/typeshed/blob/e8e9291c76f50c3bcde79e7bb61060f5c24c054e/stdlib/_csv.pyi#L17-L19

Yes, I see that. I tried some other ideas and they just didn't work.

[Dr-Irv]

Thanks @refack , especially for trying the various workarounds.