-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
API, DOC: SparseArray Interface and Documentation is Confusing #12794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
What do you mean by not "user-facing"? |
exactly what I mean. Its a detail that is hidden away from the user. Its the |
Doc already says 1D though. |
I couldn't find anything that explicitly says that in |
@gfyoung you can certainly document it more if you want. |
@jreback : Sure thing. It was just another thing I noticed as I have been squashing |
@kawochen : Fair enough, but I think the documentation internally should nevertheless reflect that as well. Perhaps it may not be for user eyes, but for developer eyes, more info is better. |
I agree. |
@gfyoung can you split this one off. |
@jreback : My computer has been acting a little weird recently, which is why I have been somewhat inactive (answering on phone ATM). I'll get to this ASAP once I get my computer checked out. |
SparseArray
inherits fromnp.ndarray
, but it doesn't seem like the instance itself can take on more than one dimension? Documentation doesn't make that super clear IMO.If having 1-D sparse arrays is the intention, then I think there should be stronger checks against multi-dimensional
data
inputs. For example, if I pass in a multi-dimensionalndarray
intoSparseArray
, I get a not so helpful error message that it does not have ansp_index
.The text was updated successfully, but these errors were encountered: