lib.is_scalar misses PEP 3141 numbers

[jbrockmendel]

Looking at np.isscalar's docstring I see:

    NumPy supports PEP 3141 numbers:

    >>> from fractions import Fraction
    >>> isscalar(Fraction(5, 17))
    True
    >>> from numbers import Number
    >>> isscalar(Number())
    True

pandas lib.is_scalar doesn't recognize Number or Fraction.

[tm9k1]

are you referring to this ?

[jbrockmendel]

Same function, yes

[tm9k1]

@jbrockmendel ok, the problem is something like this :-

The function is currently limited to the dtypes specified here.
This is backed by my findings upon close looks to the is_scalar definition for pandas,
So I need to simply add entries for some more dtypes, currently Number and Fraction.

As seen within CPython's codebase, the underlying functionality might be same as comparing through type function.

[tm9k1]

I'll just call np.isscalar() ! 😄

[tm9k1]

Yay! 🍻

…

On Tue, 20 Nov, 2018, 4:12 PM Marc Garcia, ***@***.***> wrote: Closed #22903 <#22903> via #22952 <#22952>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#22903 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AV7mM1FWtphh0njiVJFWzNK3SytdK5Jiks5uw9yAgaJpZM4XAyau> .