We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a followup from #28215
_parsers and _engines as used in the code for the .query and .eval methods should be de-privatized and named to something more informative.
.query
.eval
_engines: Dict[str, Type[AbstractEngine]] = { "numexpr": NumExprEngine, "python": PythonEngine, }
_parsers = {"python": PythonExprVisitor, "pandas": PandasExprVisitor}
@jreback
The text was updated successfully, but these errors were encountered:
theres are now ENGINES and PARSERS i think
Sorry, something went wrong.
Correct. Well I guess this can be closes then!
I also wouldn't think what a better name for those would be. I think only parser was a bit too generic term. Maybe ENGINE_PARSERS, AST_VISITOR?
ENGINES is probably good. What do you think?
These are pretty deeply internal, i wouldnt worry about it
No branches or pull requests
As a followup from #28215
_parsers and _engines as used in the code for the
.query
and.eval
methods should be de-privatized and named to something more informative.@jreback
The text was updated successfully, but these errors were encountered: