Skip to content

CI: use conda incubator in doc build #39175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fangchenli opened this issue Jan 14, 2021 · 1 comment · Fixed by #46611
Closed

CI: use conda incubator in doc build #39175

fangchenli opened this issue Jan 14, 2021 · 1 comment · Fixed by #46611
Labels
CI Continuous Integration Docs

Comments

@fangchenli
Copy link
Member

#39043 enabled conda incubator for the benchmark build. But I didn't get the doc build to work. I had something like this

web_and_docs:
    name: Web and docs
    runs-on: ubuntu-latest
    defaults:
      run:
        shell: bash -l -e {0}

    steps:
    - name: Checkout
      uses: actions/checkout@v1

    - name: Cache conda
      uses: actions/cache@v2
      with:
        path: ~/conda_pkgs_dir
        key: ${{ runner.os }}-conda-${{ hashFiles('${{ env.ENV_FILE }}') }}

    - uses: conda-incubator/setup-miniconda@v2
      with:
        activate-environment: pandas-dev
        channel-priority: strict
        environment-file: ${{ env.ENV_FILE }}
        use-only-tar-bz2: true

    - name: Environment Detail
      run: |
        conda info
        conda list

    - name: Build Pandas
      run: |
        python setup.py build_ext -j 2
        python -m pip install -e . --no-build-isolation --no-use-pep517

    - name: Build website
      run: python web/pandas_web.py web/pandas --target-path=web/build

    - name: Build documentation
      run: doc/make.py --warnings-are-errors | tee sphinx.log ; exit ${PIPESTATUS[0]}

    # This can be removed when the ipython directive fails when there are errors,
    # including the `tee sphinx.log` in te previous step (https://github.com/ipython/ipython/issues/11547)
    - name: Check ipython directive errors
      run: "! grep -B10 \"^<<<-------------------------------------------------------------------------$\" sphinx.log"

......

There are no errors in the output of doc/make.py --warnings-are-errors, but it exits with code 1. Also, using multiple workers to build the doc doesn't improve the performance.

@fangchenli fangchenli added Bug Needs Triage Issue that has not been reviewed by a pandas team member CI Continuous Integration Docs and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jan 14, 2021
@afeld
Copy link
Member

afeld commented Jan 25, 2021

using multiple workers to build the doc doesn't improve the performance

I was surprised by that too: #39366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants