Skip to content

TST: Potential inconistency between numpy and numexp #40748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twoertwein opened this issue Apr 2, 2021 · 1 comment
Closed

TST: Potential inconistency between numpy and numexp #40748

twoertwein opened this issue Apr 2, 2021 · 1 comment
Labels
expressions pd.eval, query Testing pandas testing functions or related to the test suite

Comments

@twoertwein
Copy link
Member

The loop variable engine should probably be used here instead of self.engine:

ev = pd.eval(ex, engine=self.engine, parser=self.parser)

Making this change leads to a few failed tests:

======================================================================== short test summary info =========================================================================
FAILED pandas/tests/computation/test_eval.py::TestEvalNumexprPandas::test_compound_invert_op[4-0-in] - AssertionError: Input are different
FAILED pandas/tests/computation/test_eval.py::TestEvalNumexprPandas::test_compound_invert_op[4-0-not in] - AssertionError: Input are different
FAILED pandas/tests/computation/test_eval.py::TestEvalNumexprPandas::test_compound_invert_op[4-1-in] - AssertionError: Input are different
FAILED pandas/tests/computation/test_eval.py::TestEvalNumexprPandas::test_compound_invert_op[4-1-not in] - AssertionError: Input are different
FAILED pandas/tests/computation/test_eval.py::TestEvalNumexprPandas::test_compound_invert_op[4-2-in] - AssertionError: Input are different
FAILED pandas/tests/computation/test_eval.py::TestEvalNumexprPandas::test_compound_invert_op[4-2-not in] - AssertionError: Input are different
FAILED pandas/tests/computation/test_eval.py::TestEvalNumexprPandas::test_compound_invert_op[4-3-in] - AssertionError: Input are different
FAILED pandas/tests/computation/test_eval.py::TestEvalNumexprPandas::test_compound_invert_op[4-3-not in] - AssertionError: Input are different
@twoertwein twoertwein added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 2, 2021
@rhshadrach rhshadrach added expressions pd.eval, query Testing pandas testing functions or related to the test suite and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Apr 6, 2021
@mroeschke
Copy link
Member

Looks like this got refactored in the meantime since I can't find this on main, so closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expressions pd.eval, query Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

3 participants