Skip to content

CI: disable auto-cancel for master branch #42076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fangchenli opened this issue Jun 17, 2021 · 4 comments · Fixed by #42467 or #44682
Closed

CI: disable auto-cancel for master branch #42076

fangchenli opened this issue Jun 17, 2021 · 4 comments · Fixed by #42467 or #44682
Assignees
Labels
CI Continuous Integration
Milestone

Comments

@fangchenli
Copy link
Member

fangchenli commented Jun 17, 2021

#41962 enabled auto-cancel for GitHub Actions on both master and PRs. Ideally, we should only have this feature turned on for PRs.

Auto-cancel is achieved with the concurrency feature. It looks like this:

    concurrency:
      group: ${{ github.ref }}-xxx
      cancel-in-progress: true

The group attribute specifies a group name. So only one job can run for each group.

To disable it for master, we need to select the appropriate workflow/job variables from https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions for the group name so that it's different for each commit to the master but identical for each PR.

@fangchenli fangchenli added Bug Needs Triage Issue that has not been reviewed by a pandas team member CI Continuous Integration and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 17, 2021
@lithomas1 lithomas1 self-assigned this Jul 9, 2021
@jreback jreback added this to the 1.4 milestone Jul 12, 2021
@fangchenli
Copy link
Member Author

Builds on master are been canceled recently. Not sure why.

@fangchenli fangchenli reopened this Aug 17, 2021
@lithomas1
Copy link
Member

Yep, this didn't work. Looking into it rn.

@lithomas1
Copy link
Member

I think the problem here is that when three or more commits to master are merged, the first one runs, the second one queues up fine waiting for the first one to finish, but the third commit cancels the second commits run and queues up itself.

@lithomas1 lithomas1 removed this from the 1.4 milestone Nov 29, 2021
@lithomas1
Copy link
Member

There may be hope. Gonna try https://github.community/t/concurrecy-not-work-for-push/183068/7 out.

@lithomas1 lithomas1 added this to the 1.4 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
3 participants