Skip to content

CI: Don't auto-cancel on master #42467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 12, 2021
Merged

CI: Don't auto-cancel on master #42467

merged 8 commits into from
Jul 12, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Jul 9, 2021

I haven't tested that this skips the cancel on master branch, only that it cancels already running workflows on PRs(e.g. lithomas1#3).
So, be ready to revert if needed.

@lithomas1 lithomas1 marked this pull request as ready for review July 9, 2021 18:07
@lithomas1 lithomas1 changed the title WIP: CI: Don't auto-cancel on master CI: Don't auto-cancel on master Jul 9, 2021
@lithomas1 lithomas1 requested a review from fangchenli July 9, 2021 18:07
@lithomas1 lithomas1 added the CI Continuous Integration label Jul 9, 2021
@lithomas1 lithomas1 added this to the 1.4 milestone Jul 9, 2021
Copy link
Member

@fangchenli fangchenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work.

@lithomas1 lithomas1 requested a review from jreback July 9, 2021 19:57
@fangchenli
Copy link
Member

One potential problem is this could cause a blockage if we merge many PRs in a short amount of time.

@jreback
Copy link
Contributor

jreback commented Jul 12, 2021

One potential problem is this could cause a blockage if we merge many PRs in a short amount of time.

no this is ok / fine. as we used to do exactly this.

@jreback jreback merged commit 9785f81 into pandas-dev:master Jul 12, 2021
@jreback
Copy link
Contributor

jreback commented Jul 12, 2021

thanks @lithomas1

if you'd monitor would be great.

@lithomas1 lithomas1 deleted the patch-1 branch July 19, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: disable auto-cancel for master branch
3 participants