CLN: move routines for filling missing data from core/common.py to core/missing.py #11462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +25,8 @@ | |||
| from pandas.core.categorical import Categorical, maybe_to_categorical | |||
| from pandas.tseries.index import DatetimeIndex | |||
| import pandas.core.common as com | |||
| from pandas.core.missing import (interpolate_1d, interpolate_2d, | |||
| _clean_fill_method, _clean_interp_method) | |||
There was a problem hiding this comment.
you can also so like we do for com, e.g. just import missing (and then access it), might be slightly cleaner
| @@ -1420,350 +1420,6 @@ def _fill_zeros(result, x, y, name, fill): | |||
| return result | |||
|
|
|||
|
|
|||
| def _interp_wrapper(f, wrap_dtype, na_override=None): | |||
There was a problem hiding this comment.
you might be able to strip some imports here, you might need a linter to find these though
There was a problem hiding this comment.
ran it through PyLint and didn't find any unused imports
stahlous
force-pushed
the
missing_reorg
branch
from
3f109ab to
c9b0111
Compare
|
ok looks good |
|
For internals.py and generic.py I switched to the |
jreback
added a commit
that referenced
this pull request
Oct 28, 2015
CLN: move routines for filling missing data from core/common.py to core/missing.py
|
@stahlous thanks! this was great! let's revisit the naming scheme for these in your other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the routines used for filling missing data into their own module as suggested in PR #11445.
Thoughts on re-naming
interpolate_1d()andinterpolate_2d()? They way they are currently named makes them sound like they're the same functions for arrays of differing dimensions. However,interpolate_1d()is used for interpolating with scipy interp methods whereasinterpolate_2d()is used for forward- or back-filling.