API: to_msgpack and read_msgpack encoding defaults to utf-8 #12277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -652,7 +657,10 @@ def check_min_structure(self, data): | |||
| typ], '"{0}" not found in data["{1}"]'.format(kind, typ) | |||
|
|
|||
| def compare(self, vf, version): | |||
| data = read_msgpack(vf) | |||
| if LooseVersion(version) < '0.18.0': | |||
| data = read_msgpack(vf, encoding='latin-1') | |||
There was a problem hiding this comment.
add s comment why this is the case here and a red to this issue
|
minor comment |
|
updated |
|
@kawochen thanks for the quick PR! |
cldy
pushed a commit
to cldy/pandas
that referenced
this pull request
Feb 11, 2016
closes pandas-dev#12170 Author: Ka Wo Chen <[email protected]> Closes pandas-dev#12277 from kawochen/API-12170 and squashes the following commits: 5adcf3b [Ka Wo Chen] API: to_msgpack and read_msgpack encoding defaults to utf-8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12170