Notes about unique vs cat.categories #12278 #12421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -182,6 +182,19 @@ It's also possible to pass in the categories in a specific order: | |||
| indicate an ordered ``Categorical``. | |||
|
|
|||
|
|
|||
| .. note:: | |||
|
|
|||
| Pay attention! Result of ``.unique()`` not always the same as ``Series.cat.categories``, | |||
There was a problem hiding this comment.
Don't need the "Pay attention". Add a "The" before "result". Let's change .unique() to Series.unique() to make that a bit clearer.
There was a problem hiding this comment.
dont' say 'Pay attention!', you can do a ::warning:: if you want, but a note is just fine.
The results of .unique() are not always the same as .categories.....
There was a problem hiding this comment.
@TomAugspurger hah, I think we say it at the same time!
fix note, add indent to code example fix typo
|
thanks @Dorozhko-Anton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff