BUG: date_range closed keyword with timezone aware start/end (GH12684) #13510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
| for i in intervals: | ||
| result = date_range(start=begin, end=end, closed=i) | ||
| self.assertEqual(result[0], begin) | ||
| self.assertEqual(result[-1], end) |
There was a problem hiding this comment.
I removed this test, as I think it is testing the wrong behaviour (it tests that the different closed options give all the same result, which should not be (and is not the case with naive timestamps))
jorisvandenbossche
force-pushed
the
bug-daterange-closed-tz
branch
from
43e1679 to
d5744f7
Compare
Current coverage is 84.33%@@ master #13510 diff @@
==========================================
Files 138 138
Lines 51107 51111 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43103 43107 +4
Misses 8004 8004
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12684