BUG: Error when specifying int index containing NaN #15616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Dtype Conversions
jreback
reviewed
Mar 8, 2017
|
|
||
| dtype = self.dtype | ||
| if self._is_numeric_dtype and np.any(isnull(values)): | ||
| # We can't coerce to the numeric dtype of "self" (unless |
There was a problem hiding this comment.
Breaks if values is a scalar.
There was a problem hiding this comment.
hmm, that's annoying. ok then.
|
looks good. maybe some test cases for the fail conditions that you are now catching? |
Ah, good catch. I thought I had added some. Will do. |
Codecov Report
@@ Coverage Diff @@
## master #15616 +/- ##
==========================================
- Coverage 91.02% 91% -0.02%
==========================================
Files 143 143
Lines 49324 49334 +10
==========================================
Hits 44897 44897
- Misses 4427 4437 +10
Continue to review full report at Codecov.
|
|
@jreback : Added tests, and everything is green. |
Partially addresses pandas-devgh-15187.
|
thanks! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
xref pandas-dev#15187. Author: gfyoung <[email protected]> Closes pandas-dev#15616 from gfyoung/nan-int-index and squashes the following commits: 195b830 [gfyoung] BUG: Error when specifying int index containing NaN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got around to patching this. Partially addresses #15187.