Skip to content

COMPAT: Suppress .take() warning for numpy < 1.12 #17764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2017
Merged

COMPAT: Suppress .take() warning for numpy < 1.12 #17764

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abc06e3
COMPAT: Suppress .take() warning for numpy < 1.12
gfyoung Oct 3, 2017
4f4d1ef
MAINT: Make tests pass
gfyoung Oct 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pandas/tests/sparse/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
import numpy as np
import pandas as pd

from pandas import Series, DataFrame, bdate_range, isna, compat
from pandas import (Series, DataFrame, bdate_range,
isna, compat, _np_version_under1p12)
from pandas.tseries.offsets import BDay
import pandas.util.testing as tm
from pandas.compat import range
Expand Down Expand Up @@ -527,8 +528,13 @@ def test_numpy_take(self):
sp = SparseSeries([1.0, 2.0, 3.0])
indices = [1, 2]

tm.assert_series_equal(np.take(sp, indices, axis=0).to_dense(),
np.take(sp.to_dense(), indices, axis=0))
# gh-17352: older versions of numpy don't properly
# pass in arguments to downstream .take() implementations.
warning = FutureWarning if _np_version_under1p12 else None

with tm.assert_produces_warning(warning, check_stacklevel=False):
tm.assert_series_equal(np.take(sp, indices, axis=0).to_dense(),
np.take(sp.to_dense(), indices, axis=0))

msg = "the 'out' parameter is not supported"
tm.assert_raises_regex(ValueError, msg, np.take,
Expand Down