TST: Add another test for segfault in C engine #18128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
IO CSV
Codecov Report
@@ Coverage Diff @@
## master #18128 +/- ##
==========================================
+ Coverage 91.25% 91.26% +<.01%
==========================================
Files 163 163
Lines 50122 50122
==========================================
+ Hits 45740 45743 +3
+ Misses 4382 4379 -3
Continue to review full report at Codecov.
|
jreback
reviewed
Nov 6, 2017
| @@ -359,6 +359,15 @@ def test_parse_trim_buffers(self): | |||
| # Check for data corruption if there was no segfault | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| # This extra test was added to replicate the fault in gh-5291. | |||
There was a problem hiding this comment.
worth making a different test for this?
There was a problem hiding this comment.
I think the whole point was to check whether or not the encoding argument would make a difference (notice that the calls are nearly the same). That's why I added them as such.
|
ok this is fine merge away |
watercrossing
pushed a commit
to watercrossing/pandas
that referenced
this pull request
Nov 10, 2017
No-Stream
pushed a commit
to No-Stream/pandas
that referenced
this pull request
Nov 28, 2017
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 8, 2017
xref pandas-devgh-13833. Closes pandas-devgh-5291. (cherry picked from commit 6f0ff1a)
TomAugspurger
pushed a commit
that referenced
this pull request
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why the original PR was closed, but let's bring it to completion.
xref #13833.
Closes #5291.