separate DatetimeIndex timezone tests #19545
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19545 +/- ##
==========================================
+ Coverage 91.6% 91.63% +0.02%
==========================================
Files 150 150
Lines 48750 48750
==========================================
+ Hits 44657 44670 +13
+ Misses 4093 4080 -13
Continue to review full report at Codecov.
|
jreback
added
Testing
| return timedelta(0) | ||
|
|
||
|
|
||
| fixed_off = FixedOffset(-420, '-07:00') |
There was a problem hiding this comment.
They're not being passed into parametrize anywhere.
| expected = np.repeat(np.array([3, 4, 5]), np.array([n, n, 1])) | ||
| tm.assert_index_equal(idx.hour, Index(expected)) | ||
|
|
||
| def test_dti_tz_convert_dst(self): |
There was a problem hiding this comment.
parameterize (can be next pass)
There was a problem hiding this comment.
Yah I parametrized the most egregious of these, but there is bunch of cleanup like this for the next pass.
| freq='L') | ||
| with pytest.raises(pytz.NonExistentTimeError): | ||
| dti.tz_localize(tzstr) | ||
|
|
There was a problem hiding this comment.
prob should dedupe these tz parameters into some nicely named fixtures (and push up what you can to conftest)
| localized_is_dst = dr.tz_localize(tz, ambiguous=is_dst) | ||
| tm.assert_index_equal(localized, localized_is_dst) | ||
|
|
||
| # TODO: belongs outside tz_localize tests? |
There was a problem hiding this comment.
See the "FIXME" note about 4 lines down. I'm not confident this test is testing what it is intending. This is where the existing indentation typo is: https://github.com/pandas-dev/pandas/pull/19545/files#diff-f67205b3c64b63fa7471c4221e413a19L424
|
|
||
| # ------------------------------------------------------------ | ||
| # DatetimeIndex.__new__ | ||
|
|
There was a problem hiding this comment.
hmm maybe should be in construction
| tm.assert_index_equal(idx1, other) | ||
|
|
||
| # ------------------------------------------------------------ | ||
| # Arithmetic; may belong in test_arithmetic |
|
thanks. if you can add the above items to the master TODO list would be great. I know minor, but don't want to forget about them; at the same time no reason to hold up merging this. |
|
Will do. I appreciate the leeway. |
There is probably some overlap with other tests.indexes.datetimes modules. We'll get those in the next pass.