BUG: Fix drop_duplicates failure when DataFrame has no column #20974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20974 +/- ##
==========================================
- Coverage 91.82% 91.81% -0.01%
==========================================
Files 153 153
Lines 49483 49485 +2
==========================================
Hits 45437 45437
- Misses 4046 4048 +2
Continue to review full report at Codecov.
|
jreback
added
Bug
Indexing
jreback
requested changes
May 8, 2018
| @@ -4354,6 +4354,9 @@ def duplicated(self, subset=None, keep='first'): | |||
| from pandas.core.sorting import get_group_index | |||
| from pandas._libs.hashtable import duplicated_int64, _SIZE_HINT_LIMIT | |||
|
|
|||
| if self.columns.empty: | |||
| return Series() | |||
There was a problem hiding this comment.
Good to be explicit here. We'll be changing this from float to object soon.
jreback
requested changes
Jun 19, 2018
|
0.23.2 is good. |
|
@Licht-T if you can update to comments we can put in 0.23.2 |
|
can u rebase |
|
closing in favor of #22394 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff