DOC: add cross references to advanced.rst #22671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
approved these changes
Sep 12, 2018
|
merge on green |
|
Green |
|
@topper-123 : Slow down, not quite 🙂 . AppVeyor isn't quite done yet AFAICT. |
Codecov Report
@@ Coverage Diff @@
## master #22671 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 169 169
Lines 50708 50708
=======================================
Hits 46740 46740
Misses 3968 3968
Continue to review full report at Codecov.
|
|
Ah! I was on mobile and saw the green check for ‘approved’, which is identical to the one for when tests pass... Anyway, tests are green now 😉 |
|
@topper-123 : Indeed, they are. Thanks! |
This was referenced Sep 12, 2018
aeltanawy
pushed a commit
to aeltanawy/pandas
that referenced
this pull request
Sep 20, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO the MultiIndex / Advanced Indexing section of the docs are a bit thin on cross references, so it's too difficult to make deeper looks into the API, when you are in doubt.
I've added cross references. They're added relatively sparingly, typically only the first time a concept/class type is mentioned in the document.