Skip to content

CI: Fix pyarrow compat #23266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

CI: Fix pyarrow compat #23266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cb042c
Fix pyarrow compat
jbrockmendel Oct 21, 2018
d7b0ff1
Typo fixup
jbrockmendel Oct 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pandas/io/feather_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ def _try_import():
"or via pip\n"
"pip install -U feather-format\n")

import pyarrow # used by feather; we'll need to check the version later

return feather


Expand Down Expand Up @@ -109,4 +111,9 @@ def read_feather(path, nthreads=1):
if LooseVersion(feather.__version__) < LooseVersion('0.4.0'):
return feather.read_dataframe(path)

return feather.read_dataframe(path, nthreads=nthreads)
if LooseVersion(pyarrow.__version__) < LooseVersion('0.10'):
return feather.read_dataframe(path, nthreads=nthreads)

# pyarrow>=0.10 has `use_threads` kwarg instead of `nthreads`
use_threads = nthreads > 1
return feather.read_dataframe(path, use_threads=use_threads)