Skip to content

Fix import format at pandas/tests/io/parser directory #23367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2018

Conversation

mwoss
Copy link
Contributor

@mwoss mwoss commented Oct 26, 2018

Ran isort --recursive pandas/tests/io/parser and then checked imports using isort --recursive --check-only pandas/tests/io/parser

This PR also exceeded 20 file limit (22 files with setup.cfg), but I think it's acceptable and unnecessary to divide it to two separate PRs.

@pep8speaks
Copy link

Hello @mwoss! Thanks for submitting the PR.

@jschendel jschendel added the Code Style Code style, linting, code_checks label Oct 26, 2018
@jschendel jschendel added this to the 0.24.0 milestone Oct 26, 2018
@mwoss
Copy link
Contributor Author

mwoss commented Oct 26, 2018

Tests failed due to:

The job exceeded the maximum time limit for jobs, and has been terminated.

Should I commit something to trigger build again?

@WillAyd
Copy link
Member

WillAyd commented Oct 26, 2018

Restarted the Travis job. Didn't see an option in Azure - @TomAugspurger can you help here? Am I overlooking in the UI or do I need to get something squared away with access? Was assuming I'd be able to do it as follows:

image

@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #23367 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23367   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         169      169           
  Lines       51261    51261           
=======================================
  Hits        47277    47277           
  Misses       3984     3984
Flag Coverage Δ
#multiple 90.66% <ø> (ø) ⬆️
#single 42.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caea25a...8ac1578. Read the comment docs.

@jreback jreback merged commit 690a533 into pandas-dev:master Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

thanks @mwoss

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants