Skip to content

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 27, 2018

Title is self-explanatory.

xref #15358.
xref #16005.

@gfyoung gfyoung added Visualization plotting Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Deprecate Functionality to remove in pandas Clean labels Oct 27, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Oct 27, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #23376 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23376      +/-   ##
==========================================
+ Coverage   92.16%   92.19%   +0.02%     
==========================================
  Files         166      164       -2     
  Lines       51224    51198      -26     
==========================================
- Hits        47212    47200      -12     
+ Misses       4012     3998      -14
Flag Coverage Δ
#multiple 90.62% <ø> (+0.02%) ⬆️
#single 42.23% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_style.py 77.41% <ø> (+2.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a15fa...257c3b4. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

can you rebase

@pandas-dev pandas-dev deleted a comment from jreback Oct 28, 2018
@gfyoung gfyoung force-pushed the remove-pandas-tools branch from 374bae0 to 257c3b4 Compare October 28, 2018 05:27
@gfyoung
Copy link
Member Author

gfyoung commented Oct 28, 2018

@jreback : Rebased and green. PTAL.

@jreback jreback merged commit 398d017 into pandas-dev:master Oct 28, 2018
@jreback
Copy link
Contributor

jreback commented Oct 28, 2018

thanks!

@gfyoung gfyoung deleted the remove-pandas-tools branch October 28, 2018 18:47
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Clean Deprecate Functionality to remove in pandas Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants