Skip to content

Data type of new assigned DataFrame column #23326 #23413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

charlesdong1991
Copy link
Member

@charlesdong1991 charlesdong1991 commented Oct 29, 2018

@pep8speaks
Copy link

Hello @charlesdong1991! Thanks for submitting the PR.

@gfyoung gfyoung added the Needs Info Clarification about behavior needed to assess issue label Oct 29, 2018
@gfyoung
Copy link
Member

gfyoung commented Oct 29, 2018

@charlesdong1991 : Thanks for the PR! It looks like there is no associated issue for this PR, and it's a little tricky to understand what you're fixing here.

Do you mind providing sample code that illustrates the problem you're seeing?

@gfyoung gfyoung added Dtype Conversions Unexpected or buggy dtype conversions DataFrame DataFrame data structure labels Oct 29, 2018
@charlesdong1991
Copy link
Member Author

@gfyoung sorry, i was trying to debug the issue listed in #23326 which brings up a wrong type when assigning a int type value, and getting float value as output... probably i cause more errors when dealing with it. sorry for this...
df = pd.DataFrame([list('abc')])
df.loc[:, 'col1'] = int(5)
and then the value in column is 5.0 instead of 5...
happy to know if you think it's necessary, and any suggestion of which file might cause this issue is welcome...

@gfyoung
Copy link
Member

gfyoung commented Oct 30, 2018

@charlesdong1991 : Ah, no worries. Thanks for linking the existing the issue!

@charlesdong1991
Copy link
Member Author

sorry, wasn't able to find the issue and had some holidays... will leave it to other people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataFrame DataFrame data structure Dtype Conversions Unexpected or buggy dtype conversions Needs Info Clarification about behavior needed to assess issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data type of new assigned DataFrame column
3 participants