-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: Fixing benchmark log #24062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Fixing benchmark log #24062
Conversation
…ded a benchmark error, so the error is displayed in the CI
Hello @datapythonista! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #24062 +/- ##
=======================================
Coverage 92.31% 92.31%
=======================================
Files 161 161
Lines 51562 51562
=======================================
Hits 47599 47599
Misses 3963 3963
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24062 +/- ##
=========================================
Coverage ? 92.31%
=========================================
Files ? 161
Lines ? 51562
Branches ? 0
=========================================
Hits ? 47599
Misses ? 3963
Partials ? 0
Continue to review full report at Codecov.
|
@gfyoung, can you take a look at the benchmark log. Will fix the error when you confirm, so we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better. Thanks!
can you point to the errored one? |
nvm I saw it. ok remove the error and push and can merge. |
thanks @datapythonista |
git diff upstream/master -u -- "*.py" | flake8 --diff