Skip to content

CI: Fixing benchmark log #24062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2018
Merged

CI: Fixing benchmark log #24062

merged 3 commits into from
Dec 3, 2018

Conversation

datapythonista
Copy link
Member

@datapythonista datapythonista commented Dec 3, 2018

…ded a benchmark error, so the error is displayed in the CI
@pep8speaks
Copy link

Hello @datapythonista! Thanks for submitting the PR.

Line 4:1: E265 block comment should start with '# '

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #24062 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24062   +/-   ##
=======================================
  Coverage   92.31%   92.31%           
=======================================
  Files         161      161           
  Lines       51562    51562           
=======================================
  Hits        47599    47599           
  Misses       3963     3963
Flag Coverage Δ
#multiple 90.71% <ø> (ø) ⬆️
#single 42.44% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7bdf7c...9ad10e5. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@a7bb972). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #24062   +/-   ##
=========================================
  Coverage          ?   92.31%           
=========================================
  Files             ?      161           
  Lines             ?    51562           
  Branches          ?        0           
=========================================
  Hits              ?    47599           
  Misses            ?     3963           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.71% <ø> (?)
#single 42.44% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bb972...9eae303. Read the comment docs.

@datapythonista
Copy link
Member Author

@gfyoung, can you take a look at the benchmark log. Will fix the error when you confirm, so we can merge.

@jreback jreback added the CI Continuous Integration label Dec 3, 2018
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better. Thanks!

@jreback
Copy link
Contributor

jreback commented Dec 3, 2018

can you point to the errored one?

@jreback
Copy link
Contributor

jreback commented Dec 3, 2018

nvm I saw it.

ok remove the error and push and can merge.

@jreback jreback added this to the 0.24.0 milestone Dec 3, 2018
@datapythonista datapythonista changed the title WIP/CI: Fixing benchmark log CI: Fixing benchmark log Dec 3, 2018
@jreback jreback merged commit 5f963c8 into pandas-dev:master Dec 3, 2018
@jreback
Copy link
Contributor

jreback commented Dec 3, 2018

thanks @datapythonista

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Log of the benchmarks doesn't keep the line breaks
4 participants