-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CLN: Remove Panel benchmarks #25646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: Remove Panel benchmarks #25646
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25646 +/- ##
==========================================
- Coverage 91.26% 91.26% -0.01%
==========================================
Files 173 173
Lines 52968 52968
==========================================
- Hits 48340 48339 -1
- Misses 4628 4629 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25646 +/- ##
=======================================
Coverage 91.24% 91.24%
=======================================
Files 172 172
Lines 52967 52967
=======================================
Hits 48332 48332
Misses 4635 4635
Continue to review full report at Codecov.
|
Hmm the ASV doc failures looks to be the same issue as #24839 potentially. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge this. It won't continue to fail master, since the benchmarks are only run on PRs that touch the asv files.
Agreed. Additionally the failing benchmarks are not related to the Panel changes. Merging. |
xref #25632