Skip to content

CLN: Remove Panel benchmarks #25646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 14, 2019

Conversation

mroeschke
Copy link
Member

xref #25632

@mroeschke mroeschke added Clean Panel Benchmark Performance (ASV) benchmarks labels Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #25646 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25646      +/-   ##
==========================================
- Coverage   91.26%   91.26%   -0.01%     
==========================================
  Files         173      173              
  Lines       52968    52968              
==========================================
- Hits        48340    48339       -1     
- Misses       4628     4629       +1
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.71% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 87.57% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f886139...00102b8. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #25646 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25646   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files         172      172           
  Lines       52967    52967           
=======================================
  Hits        48332    48332           
  Misses       4635     4635
Flag Coverage Δ
#multiple 89.82% <ø> (ø) ⬆️
#single 41.74% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1017382...b4917f9. Read the comment docs.

@mroeschke
Copy link
Member Author

Hmm the ASV doc failures looks to be the same issue as #24839 potentially.

Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this. It won't continue to fail master, since the benchmarks are only run on PRs that touch the asv files.

@mroeschke
Copy link
Member Author

Agreed. Additionally the failing benchmarks are not related to the Panel changes.

Merging.

@mroeschke mroeschke merged commit 9eec9b8 into pandas-dev:master Mar 14, 2019
@mroeschke mroeschke deleted the remove_panel_benchmarks branch March 14, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks Clean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants