Skip to content

BUG: DataFrame.update with tz-aware date doesn't return naive data #25810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

mroeschke
Copy link
Member

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #25810 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25810   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         173      173           
  Lines       53002    53002           
=======================================
  Hits        48375    48375           
  Misses       4627     4627
Flag Coverage Δ
#multiple 89.83% <100%> (ø) ⬆️
#single 41.77% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 96.79% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe2523...116e8dd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #25810 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25810   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         173      173           
  Lines       53002    53002           
=======================================
  Hits        48375    48375           
  Misses       4627     4627
Flag Coverage Δ
#multiple 89.83% <100%> (ø) ⬆️
#single 41.77% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 96.79% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe2523...116e8dd. Read the comment docs.

@WillAyd WillAyd added Datetime Datetime data dtype DataFrame DataFrame data structure labels Mar 21, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Mar 21, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback merged commit 8b56ea3 into pandas-dev:master Mar 21, 2019
@jreback
Copy link
Contributor

jreback commented Mar 21, 2019

thanks @mroeschke

I think this might close one or more outstanding update issues (other than the OP of course)

@mroeschke mroeschke deleted the timezone_update branch March 21, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataFrame DataFrame data structure Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame.update() drops timezone info
3 participants